[uss_qualifier] Add scenario for testing data validation by SUT for Get operational_intent #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BenjaminPelletier Could you please review this PR for data validation scenario. Thanks |
Yes, but please try to follow the standard contributing process -- this includes the use of GitHub's tools to indicate review readiness by clicking "Ready for review" 
|
|
I was not sure, if you would first like to review in draft. I ll move to Ready for review. |
|
@BenjaminPelletier PR is ready for your review. Thanks |
...er/scenarios/astm/utm/interuss/data_exchange_validation/scd_get_op_data_validation_by_sut.md
Outdated
Show resolved
Hide resolved
...er/scenarios/astm/utm/interuss/data_exchange_validation/scd_get_op_data_validation_by_sut.md
Outdated
Show resolved
Hide resolved
...er/scenarios/astm/utm/interuss/data_exchange_validation/scd_get_op_data_validation_by_sut.md
Outdated
Show resolved
Hide resolved
...er/scenarios/astm/utm/interuss/data_exchange_validation/scd_get_op_data_validation_by_sut.md
Outdated
Show resolved
Hide resolved
...er/scenarios/astm/utm/interuss/data_exchange_validation/scd_get_op_data_validation_by_sut.md
Outdated
Show resolved
Hide resolved
.../interuss/data_exchange_validation/test_steps/validate_no_notification_operational_intent.md
Outdated
Show resolved
Hide resolved
...er/scenarios/astm/utm/interuss/data_exchange_validation/scd_get_op_data_validation_by_sut.md
Outdated
Show resolved
Hide resolved
...er/scenarios/astm/utm/interuss/data_exchange_validation/scd_get_op_data_validation_by_sut.md
Outdated
Show resolved
Hide resolved
...er/scenarios/astm/utm/interuss/data_exchange_validation/scd_get_op_data_validation_by_sut.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/test_data/usa/kentland/flight_intents/non_conflicting.yaml
Outdated
Show resolved
Hide resolved
… in the test scenario and test steps readme files
|
@BenjaminPelletier PR ready for your review. |
monitoring/uss_qualifier/requirements/interuss/mock_uss/interactions.md
Outdated
Show resolved
Hide resolved
...os/astm/utm/interuss/data_exchange_validation/test_steps/plan_flight_intent_expect_failed.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/data_exchange_validation/get_op_data_validation.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/data_exchange_validation/get_op_data_validation.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/data_exchange_validation/get_op_data_validation.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/data_exchange_validation/get_op_data_validation.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/data_exchange_validation/get_op_data_validation.md
Outdated
Show resolved
Hide resolved
BenjaminPelletier
approved these changes
Nov 3, 2023
| ### [Validate flight 2 sharing test step](../validate_shared_operational_intent.md) | ||
| Validate that flight 2 is planned | ||
|
|
||
| ### Precondition - check tested_uss has no subscription in flight 2 area test step |
There was a problem hiding this comment.
nit: The successful mock_uss interactions retreival check will probably still be valid here, but we can add marginal/additional checks at implementation time -- that's not a core check of the scenario, so no need to change before merging this PR.
There was a problem hiding this comment.
Ok. So, should we raise an exception for mock_uss interaction retrieval check and notification not sent? And accordingly continue or stop the scenario.
BenjaminPelletier
changed the title
github-actions bot
added a commit
that referenced
this pull request
Nov 3, 2023
…et operational_intent (#293) * Scenario for testing data validation by SUT for Get operational_intent * Removing an import * Fix format * Add interactions requirement file * Adding more description to the scenario * Scenario documentation fix * Improved requirements description * Per PR comments, fixed module path, file name, checks and description in the test scenario and test steps readme files * Per PR comments removing py files, and improving description * Per PR review, created a new requirement for no notifications * Adding empty sceanrio and fixing documentation links * Fix format * Fix the requirement reference in documentation * Documentation change per PR * Removed requirement reference from test step, as per PR review * Added more description to test steps * Fix per PR review * Removed time_range suffix for flight intents, as per PR comment * Remover time_range_A suffix from flight intent * Revert "Remover time_range_A suffix from flight intent" This reverts commit 4a3df76. * Removed time_range_A suffix from flight intents * Removing unreferenced file and description per PR review * fixing variable name per PR reveiw * Removed link for no notification pushed * Fixed removing link * Fix link * Removing check from a precondition step as per PR review 353b9cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First scenario for testing data validation of GetOperationalIntentDetailsResponse by SUT.